Does this sound like a reasonable...?

...system of Classical Elements for my fantasy series? (Classical Elements being like Earth Fire Wind and Water) So I have the main four elements there and then four more so total I have Earth Air Fire Water Stone Ice Wood and Smoke. Does this sound like a good, fairly broad list? Are any missing? Any other suggestions? It's kind of important there are eight of them so if you think a few should be omitted and replaced I am open to suggestion! :) Thanks!